Added support for component specific css. #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/nativescript-angular/renderer.ts
Outdated
| private hasComponentStyles: boolean; | ||
| constructor(private _rootRenderer: NativeScriptRootRenderer, private componentProto: RenderComponentType) { | ||
| super(); | ||
| let page =<Page>(<any>topmost()).currentPage; |
There was a problem hiding this comment.
I propose we move the code that gets the current page to the root renderer and access it from there in child renderers. This will remove the duplication with selectRootElement
|
Related to #56 |
nsndeck
force-pushed
the
nnikolov/ComponentCssSupport
branch
from
7db2e10 to
58e9fe6
Compare
nsndeck
pushed a commit
that referenced
this pull request
Feb 16, 2016
Added support for component specific css.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.